setsys_settings_items: Less resource churn with combined key/value construction
The previous string construction discards two temporary std::string
instances (operator+ returns by value, not by reference), and creates a
std::string that it doesn't need to (the one around key). Instead we can
just append to the end of the initial std::string itself, saving on two
unnecessary created strings.

append() has a const char* overload as well (as does operator+), so we
can just append the key string as is without creating an entire new
string.
1 parent 452c61d commit dd10547ac23bdd9f834ab9864162978ef8105cd7
@Lioncash Lioncash authored on 4 Jun 2019
Showing 1 changed file
View
stratosphere/ams_mitm/source/set_mitm/setsys_settings_items.cpp