diff --git a/gateway/src/events/Close.ts b/gateway/src/events/Close.ts index b4fed31..2f274ec 100644 --- a/gateway/src/events/Close.ts +++ b/gateway/src/events/Close.ts @@ -4,7 +4,7 @@ export async function Close(this: WebSocket, code: number, reason: string) { console.log("[WebSocket] closed", code, reason); - await Session.delete({ session_id: this.session_id }); + if (this.session_id) await Session.delete({ session_id: this.session_id }); // @ts-ignore this.off("message", Message); } diff --git a/gateway/src/opcodes/VoiceStateUpdate.ts b/gateway/src/opcodes/VoiceStateUpdate.ts index 04392b6..fba0db1 100644 --- a/gateway/src/opcodes/VoiceStateUpdate.ts +++ b/gateway/src/opcodes/VoiceStateUpdate.ts @@ -2,7 +2,7 @@ import { Payload } from "../util/Constants"; import WebSocket from "../util/WebSocket"; import { check } from "./instanceOf"; -import { Config, emitEvent, VoiceServerUpdateEvent, VoiceState, VoiceStateUpdateEvent } from "@fosscord/util"; +import { Config, emitEvent, Member, VoiceServerUpdateEvent, VoiceState, VoiceStateUpdateEvent } from "@fosscord/util"; import { genVoiceToken } from "../util/SessionUtils"; // TODO: check if a voice server is setup // Notice: Bot users respect the voice channel's user limit, if set. When the voice channel is full, you will not receive the Voice State Update or Voice Server Update events in response to your own Voice State Update. Having MANAGE_CHANNELS permission bypasses this limit and allows you to join regardless of the channel being full or not. @@ -14,8 +14,7 @@ let voiceState; try { voiceState = await VoiceState.findOneOrFail({ - where: { user_id: this.user_id }, - relations: ["member", "member.user", "member.roles"], + where: { user_id: this.user_id } }); if (voiceState.session_id !== this.session_id && body.channel_id === null) { //Should we also check guild_id === null? @@ -23,6 +22,15 @@ return; } + //If a user change voice channel between guild we should send a left event first + if (voiceState.guild_id !== body.guild_id && voiceState.session_id === this.session_id) { + await emitEvent({ + event: "VOICE_STATE_UPDATE", + data: { ...voiceState, channel_id: null }, + guild_id: voiceState.guild_id, + }) + } + //The event send by Discord's client on channel leave has both guild_id and channel_id as null if (body.guild_id === null) body.guild_id = voiceState.guild_id; voiceState.assign(body); @@ -36,12 +44,18 @@ }); } + //TODO the member should only have these properties: hoisted_role, deaf, joined_at, mute, roles, user + //TODO the member.user should only have these properties: avatar, discriminator, id, username + //TODO this may fail + voiceState.member = await Member.findOneOrFail({ + where: { id: voiceState.user_id, guild_id: voiceState.guild_id }, + relations: ["user", "roles"], + }) + //If the session changed we generate a new token if (voiceState.session_id !== this.session_id) voiceState.token = genVoiceToken(); voiceState.session_id = this.session_id; - //TODO the member should only have these properties: hoisted_role, deaf, joined_at, mute, roles, user - //TODO the member.user should only have these properties: avatar, discriminator, id, username const { id, ...newObj } = voiceState; await Promise.all([ diff --git a/util/src/entities/VoiceState.ts b/util/src/entities/VoiceState.ts index d7a032c..56eb244 100644 --- a/util/src/entities/VoiceState.ts +++ b/util/src/entities/VoiceState.ts @@ -32,8 +32,9 @@ @ManyToOne(() => User) user: User; - @JoinColumn({ name: "user_id" }) - @ManyToOne(() => Member) + // @JoinColumn([{ name: "user_id", referencedColumnName: "id" },{ name: "guild_id", referencedColumnName: "guild_id" }]) + // @ManyToOne(() => Member) + //TODO find a way to make it work without breaking Guild.voice_states member: Member; @Column()